copyFileToAbstractedPath can returns false on failure, but code assumes it throws

[Xon]

Many of the places which call \XF\Util\File::copyFileToAbstractedPath assumes it will throw on error, and with most of the default providers they do. But the return of putStream can return false depending on the underlying provider at which point XF assumes things have worked.

This affects thumbnail rebuilding and likely a few other bits that call copyFileToAbstractedPath that probably need checking. I feel copyFileToAbstractedPath should throw if...

Read more